Skip to content
Snippets Groups Projects
Commit 93d475ee authored by Rhys Arkins's avatar Rhys Arkins
Browse files

fix(cdnjs): datasourceError on unknown error

parent cbee46d0
No related merge requests found
......@@ -45,9 +45,11 @@ describe('datasource/cdnjs', () => {
jest.clearAllMocks();
return global.renovateCache.rmAll();
});
it('returns null for empty result', async () => {
it('throws for empty result', async () => {
got.mockResolvedValueOnce(null);
expect(await getPkgReleases({ lookupName: 'foo/bar' })).toBeNull();
await expect(
getPkgReleases({ lookupName: 'foo/bar' })
).rejects.toThrowError(DATASOURCE_FAILURE);
});
it('returns null for missing fields', async () => {
got.mockResolvedValueOnce({});
......@@ -77,7 +79,9 @@ describe('datasource/cdnjs', () => {
got.mockImplementationOnce(() => {
throw new Error();
});
expect(await getPkgReleases({ lookupName: 'foo/bar' })).toBeNull();
await expect(
getPkgReleases({ lookupName: 'foo/bar' })
).rejects.toThrowError(DATASOURCE_FAILURE);
});
it('returns null with wrong auth token', async () => {
got.mockRejectedValueOnce({ statusCode: 401 });
......
......@@ -101,13 +101,13 @@ export async function getPkgReleases({
) {
throw new DatasourceError(err);
}
if (err.statusCode === 401) {
logger.debug(errorData, 'Authorization error');
} else if (err.statusCode === 404) {
logger.debug(errorData, 'Package lookup error');
} else {
logger.warn(errorData, 'CDNJS lookup failure: Unknown error');
logger.debug(errorData, 'CDNJS lookup failure: Unknown error');
throw new DatasourceError(err);
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment