Skip to content
Snippets Groups Projects
Commit a49a58c5 authored by Rhys Arkins's avatar Rhys Arkins
Browse files

refactor: getLockFile -> getArtifacts

parent 3cc664f4
No related branches found
No related tags found
No related merge requests found
......@@ -5,16 +5,16 @@ const os = require('os');
const hostRules = require('../../util/host-rules');
module.exports = {
getLockFile,
getArtifacts,
};
async function getLockFile(
async function getArtifacts(
packageFileName,
updatedDeps,
newPackageFileContent,
config
) {
logger.debug(`composer.getLockFile(${packageFileName})`);
logger.debug(`composer.getArtifacts(${packageFileName})`);
process.env.COMPOSER_CACHE_DIR =
process.env.COMPOSER_CACHE_DIR ||
upath.join(os.tmpdir(), '/renovate/cache/composer');
......
const { extractDependencies } = require('./extract');
const { updateDependency } = require('../npm/update');
const { getLockFile } = require('./lock-file');
const { getArtifacts } = require('./artifacts');
const language = 'php';
module.exports = {
extractDependencies,
getLockFile,
getArtifacts,
language,
updateDependency,
// TODO: support this
......
......@@ -56,9 +56,9 @@ async function getUpdatedPackageFiles(config) {
for (const packageFile of updatedPackageFiles) {
const manager = packageFileManagers[packageFile.name];
const updatedDeps = packageFileUpdatedDeps[packageFile.name];
const getLockFile = get(manager, 'getLockFile');
if (getLockFile) {
const updatedLockFile = await getLockFile(
const getArtifacts = get(manager, 'getArtifacts');
if (getArtifacts) {
const updatedLockFile = await getArtifacts(
packageFile.name,
updatedDeps,
packageFile.contents,
......
......@@ -3,19 +3,19 @@ jest.mock('child-process-promise');
const fs = require('fs-extra');
const { exec } = require('child-process-promise');
const composer = require('../../../lib/manager/composer/lock-file');
const composer = require('../../../lib/manager/composer/artifacts');
const config = {
localDir: '/tmp/github/some/repo',
};
describe('.getLockFile()', () => {
describe('.getArtifacts()', () => {
beforeEach(() => {
jest.resetAllMocks();
});
it('returns if no composer.lock found', async () => {
expect(
await composer.getLockFile('composer.json', [], '{}', config)
await composer.getArtifacts('composer.json', [], '{}', config)
).toBeNull();
});
it('returns null if unchanged', async () => {
......@@ -26,7 +26,7 @@ describe('.getLockFile()', () => {
});
fs.readFile = jest.fn(() => 'Current composer.lock');
expect(
await composer.getLockFile('composer.json', [], '{}', config)
await composer.getArtifacts('composer.json', [], '{}', config)
).toBeNull();
});
it('returns updated composer.lock', async () => {
......@@ -37,7 +37,7 @@ describe('.getLockFile()', () => {
});
fs.readFile = jest.fn(() => 'New composer.lock');
expect(
await composer.getLockFile('composer.json', [], '{}', config)
await composer.getArtifacts('composer.json', [], '{}', config)
).not.toBeNull();
});
it('supports docker mode', async () => {
......@@ -48,7 +48,7 @@ describe('.getLockFile()', () => {
});
fs.readFile = jest.fn(() => 'New composer.lock');
expect(
await composer.getLockFile('composer.json', [], '{}', {
await composer.getArtifacts('composer.json', [], '{}', {
...config,
binarySource: 'docker',
})
......@@ -60,7 +60,7 @@ describe('.getLockFile()', () => {
throw new Error('not found');
});
expect(
await composer.getLockFile('composer.json', [], '{}', config)
await composer.getArtifacts('composer.json', [], '{}', config)
).toBeNull();
});
});
......@@ -14,7 +14,7 @@ describe('workers/branch/get-updated', () => {
upgrades: [],
};
composer.updateDependency = jest.fn();
composer.getLockFile = jest.fn();
composer.getArtifacts = jest.fn();
npm.updateDependency = jest.fn();
});
it('handles empty', async () => {
......@@ -49,7 +49,7 @@ describe('workers/branch/get-updated', () => {
manager: 'composer',
});
composer.updateDependency.mockReturnValue('some new content');
composer.getLockFile.mockReturnValue({
composer.getArtifacts.mockReturnValue({
name: 'composer.json',
contents: 'some contents',
});
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment