Skip to content
Snippets Groups Projects
Unverified Commit a6843734 authored by Rhys Arkins's avatar Rhys Arkins Committed by GitHub
Browse files

fix: global cache return undefined instead of null (#6530)

parent f5a588eb
No related branches found
No related tags found
No related merge requests found
......@@ -7,7 +7,9 @@ describe('lib/util/cache/global/file', () => {
});
it('gets null', async () => {
expect(await global.renovateCache.get('test', 'missing-key')).toBeNull();
expect(
await global.renovateCache.get('test', 'missing-key')
).toBeUndefined();
});
it('sets and gets', async () => {
......@@ -17,6 +19,6 @@ describe('lib/util/cache/global/file', () => {
it('expires', async () => {
await global.renovateCache.set('test', 'key', 1234, -5);
expect(await global.renovateCache.get('test', 'key')).toBeNull();
expect(await global.renovateCache.get('test', 'key')).toBeUndefined();
});
});
......@@ -18,7 +18,6 @@ async function get<T = never>(namespace: string, key: string): Promise<T> {
try {
const res = await cacache.get(renovateCache, getKey(namespace, key));
const cachedValue = JSON.parse(res.data.toString());
// istanbul ignore else: only happens when cache is corrupted
if (cachedValue) {
if (DateTime.local() < DateTime.fromISO(cachedValue.expiry)) {
logger.trace({ namespace, key }, 'Returning cached value');
......@@ -29,7 +28,7 @@ async function get<T = never>(namespace: string, key: string): Promise<T> {
} catch (err) {
logger.trace({ namespace, key }, 'Cache miss');
}
return null;
return undefined;
}
async function set(
......
......@@ -38,7 +38,7 @@ async function get<T = never>(namespace: string, key: string): Promise<T> {
} catch (err) {
logger.trace({ namespace, key }, 'Cache miss');
}
return null;
return undefined;
}
async function set(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment