Skip to content
Snippets Groups Projects
Unverified Commit ad7ae2a7 authored by Michael Kriese's avatar Michael Kriese Committed by GitHub
Browse files

fix(datasource/dart-version): skip old svn revisions (#34059)

parent f975b74f
No related branches found
No related tags found
No related merge requests found
......@@ -10,6 +10,8 @@
"channels/beta/release/2.19.0-255.2.beta/",
"channels/beta/release/2.19.0-374.1.beta/",
"channels/beta/release/2.19.0-374.2.beta/",
"channels/dev/release/30039/",
"channels/dev/release/30104/",
"channels/beta/release/latest/"
]
}
......@@ -7,6 +7,8 @@
"channels/stable/release/2.18.0/",
"channels/stable/release/2.18.4/",
"channels/stable/release/2.18.5/",
"channels/stable/release/30036/",
"channels/stable/release/30107/",
"channels/stable/release/latest/"
]
}
......@@ -5,6 +5,12 @@ import type { GetReleasesConfig, Release, ReleaseResult } from '../types';
import type { DartResponse } from './types';
export const stableVersionRegex = regEx(/^\d+\.\d+\.\d+$/);
/**
* The server returns old svn versions which would need mapping to a version.
* They are very old, so we skip them instead.
* https://github.com/dart-lang/site-www/blob/7d4409c87bb6570b2d8870b20283f81f2b7e08fc/tool/get-dart/dart_sdk_archive/lib/src/svn_versions.dart#L2
*/
export const svnVersionRegex = regEx(/^\d+$/);
export class DartVersionDatasource extends Datasource {
static readonly id = 'dart-version';
......@@ -65,6 +71,8 @@ export class DartVersionDatasource extends Datasource {
.filter((version) => {
if (
version === 'latest' ||
// skip old svn versions
svnVersionRegex.test(version) ||
// The API response contains a stable version being released as a non-stable
// release. So we filter out these releases here.
(channel !== 'stable' && stableVersionRegex.test(version))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment