Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
renovate
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
GitHub Mirror
Renovate Bot
renovate
Commits
cc4df96f
Commit
cc4df96f
authored
7 years ago
by
Rhys Arkins
Browse files
Options
Downloads
Patches
Plain Diff
fix: return early if docker token acquisition fails
parent
a302b11a
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
lib/datasource/docker.js
+24
-7
24 additions, 7 deletions
lib/datasource/docker.js
with
24 additions
and
7 deletions
lib/datasource/docker.js
+
24
−
7
View file @
cc4df96f
...
@@ -38,13 +38,21 @@ async function getAuthHeaders(registry, repository) {
...
@@ -38,13 +38,21 @@ async function getAuthHeaders(registry, repository) {
Authorization
:
`Bearer
${
token
}
`
,
Authorization
:
`Bearer
${
token
}
`
,
Accept
:
'
application/vnd.docker.distribution.manifest.v2+json
'
,
Accept
:
'
application/vnd.docker.distribution.manifest.v2+json
'
,
};
};
}
catch
(
err
)
{
}
catch
(
err
)
/* istanbul ignore next */
{
// istanbul ignore if
if
(
err
.
statusCode
===
401
)
{
logger
.
info
({
registry
,
repository
},
'
Unauthorized docker lookup
'
);
logger
.
debug
({
err
,
message
:
err
.
message
,
body
:
err
.
response
?
err
.
response
.
body
:
undefined
,
});
return
null
;
}
if
(
err
.
statusCode
>=
500
&&
err
.
statusCode
<
600
)
{
if
(
err
.
statusCode
>=
500
&&
err
.
statusCode
<
600
)
{
logger
.
warn
({
err
},
'
docker registry failure: internal error
'
);
logger
.
warn
({
err
},
'
docker registry failure: internal error
'
);
throw
new
Error
(
'
registry-failure
'
);
throw
new
Error
(
'
registry-failure
'
);
}
}
logger
.
info
(
'
Error obtaining docker token
'
);
logger
.
warn
(
'
Error obtaining docker token
'
);
return
null
;
return
null
;
}
}
}
}
...
@@ -56,6 +64,10 @@ async function getDigest(registry, name, tag = 'latest') {
...
@@ -56,6 +64,10 @@ async function getDigest(registry, name, tag = 'latest') {
try
{
try
{
const
url
=
`
${
massagedRegistry
}
/v2/
${
repository
}
/manifests/
${
tag
}
`
;
const
url
=
`
${
massagedRegistry
}
/v2/
${
repository
}
/manifests/
${
tag
}
`
;
const
headers
=
await
getAuthHeaders
(
massagedRegistry
,
repository
);
const
headers
=
await
getAuthHeaders
(
massagedRegistry
,
repository
);
if
(
!
headers
)
{
logger
.
info
(
'
No docker auth found - returning
'
);
return
null
;
}
headers
.
accept
=
'
application/vnd.docker.distribution.manifest.v2+json
'
;
headers
.
accept
=
'
application/vnd.docker.distribution.manifest.v2+json
'
;
const
digest
=
(
await
got
(
url
,
{
json
:
true
,
headers
,
timeout
:
10000
}))
const
digest
=
(
await
got
(
url
,
{
json
:
true
,
headers
,
timeout
:
10000
}))
.
headers
[
'
docker-content-digest
'
];
.
headers
[
'
docker-content-digest
'
];
...
@@ -63,10 +75,12 @@ async function getDigest(registry, name, tag = 'latest') {
...
@@ -63,10 +75,12 @@ async function getDigest(registry, name, tag = 'latest') {
return
digest
;
return
digest
;
}
catch
(
err
)
/* istanbul ignore next */
{
}
catch
(
err
)
/* istanbul ignore next */
{
if
(
err
.
statusCode
===
401
)
{
if
(
err
.
statusCode
===
401
)
{
logger
.
info
(
logger
.
info
({
registry
,
repository
},
'
Unauthorized docker lookup
'
);
{
err
,
body
:
err
.
response
?
err
.
response
.
body
:
undefined
,
name
,
tag
},
logger
.
debug
({
'
Lookup is unauthorized (private image)
'
err
,
);
message
:
err
.
message
,
body
:
err
.
response
?
err
.
response
.
body
:
undefined
,
});
return
null
;
return
null
;
}
}
if
(
err
.
statusCode
===
404
)
{
if
(
err
.
statusCode
===
404
)
{
...
@@ -106,6 +120,9 @@ async function getTags(registry, name) {
...
@@ -106,6 +120,9 @@ async function getTags(registry, name) {
try
{
try
{
let
url
=
`
${
massagedRegistry
}
/v2/
${
repository
}
/tags/list?n=10000`
;
let
url
=
`
${
massagedRegistry
}
/v2/
${
repository
}
/tags/list?n=10000`
;
const
headers
=
await
getAuthHeaders
(
massagedRegistry
,
repository
);
const
headers
=
await
getAuthHeaders
(
massagedRegistry
,
repository
);
if
(
!
headers
)
{
return
null
;
}
let
tags
=
[];
let
tags
=
[];
let
page
=
1
;
let
page
=
1
;
do
{
do
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment