fix(docker): skip sources containing variables

lib/manager/dockerfile/extract.js

@@ -7,6 +7,11 @@ module.exports = {
 
 function splitImageParts(currentFrom) {
   let dockerRegistry;
+  if (currentFrom.includes('${')) {
+    return {
+      skipReason: 'contains-variable',
+    };
+  }
   const split = currentFrom.split('/');
   if (split.length > 1 && split[0].includes('.')) {
     [dockerRegistry] = split;
@@ -41,6 +46,7 @@ function getDep(currentFrom) {
   const purl = getPurl(dep.dockerRegistry, dep.depName);
   dep.purl = purl;
   if (
+    dep.depName &&
     (dep.depName === 'node' || dep.depName.endsWith('/node')) &&
     dep.depName !== 'calico/node'
   ) {

test/_fixtures/docker-compose/docker-compose.1.yml

@@ -87,6 +87,9 @@ services:
       placement:
         constraints: [node.role == manager]
 
+  edplugins:
+    image: ${IMAGE:-synkodevelopers/edplugins}:${TAG:-latest}
+
 networks:
   frontend:
   backend:

test/manager/docker-compose/__snapshots__/extract.spec.js.snap

@@ -80,5 +80,11 @@ Array [
     "lineNumber": 79,
     "purl": "pkg:docker/dockersamples/visualizer",
   },
+  Object {
+    "currentFrom": "\${IMAGE:-synkodevelopers/edplugins}:\${TAG:-latest}",
+    "lineNumber": 90,
+    "purl": "pkg:docker/undefined",
+    "skipReason": "contains-variable",
+  },
 ]
 `;

test/manager/docker-compose/extract.spec.js

@@ -20,7 +20,7 @@ describe('lib/manager/docker-compose/extract', () => {
     it('extracts multiple image lines', () => {
       const res = extractPackageFile(yamlFile, config);
       expect(res.deps).toMatchSnapshot();
-      expect(res.deps).toHaveLength(7);
+      expect(res.deps).toHaveLength(8);
     });
   });
 });