feat(npm): perform full install if file: references found

npm’s —package-lock-only implementation seems to have a bug and produces incorrect lock files when file: references are present. If file: dependencies are detected, skipInstalls is set to false.

Closes #2401

lib/manager/npm/extract/index.js

@@ -95,6 +95,7 @@ async function extractDependencies(content, packageFile, config) {
   let lernaDir;
   let lernaPackages;
   let lernaClient;
+  let skipInstalls = true;
   const lernaJson = JSON.parse(
     await platform.getFile(upath.join(path.dirname(packageFile), 'lerna.json'))
   );
@@ -138,6 +139,7 @@ async function extractDependencies(content, packageFile, config) {
             }
           } else if (dep.currentValue.startsWith('file:')) {
             dep.skipReason = 'file';
+            skipInstalls = false;
           } else if (semver.isValid(dep.currentValue)) {
             dep.purl = `pkg:npm/${depName.replace('@', '%40')}`;
             if (dep.currentValue === '*') {
@@ -192,6 +194,7 @@ async function extractDependencies(content, packageFile, config) {
     lernaDir,
     lernaClient,
     lernaPackages,
+    skipInstalls,
     yarnWorkspacesPackages,
   };
 }

test/manager/npm/extract/__snapshots__/index.spec.js.snap

@@ -102,6 +102,7 @@ Object {
   "packageJsonType": "app",
   "packageJsonVersion": undefined,
   "pnpmShrinkwrap": undefined,
+  "skipInstalls": false,
   "yarnLock": undefined,
   "yarnWorkspacesPackages": undefined,
   "yarnrc": undefined,
@@ -201,6 +202,7 @@ Object {
   "packageJsonType": "app",
   "packageJsonVersion": "1.0.0",
   "pnpmShrinkwrap": undefined,
+  "skipInstalls": true,
   "yarnLock": "yarn.lock",
   "yarnWorkspacesPackages": undefined,
   "yarnrc": undefined,
@@ -219,6 +221,7 @@ Object {
   "packageJsonType": "app",
   "packageJsonVersion": "0.0.8",
   "pnpmShrinkwrap": undefined,
+  "skipInstalls": true,
   "yarnLock": undefined,
   "yarnWorkspacesPackages": Array [
     "packages/*",
@@ -320,6 +323,7 @@ Object {
   "packageJsonType": "app",
   "packageJsonVersion": "1.0.0",
   "pnpmShrinkwrap": undefined,
+  "skipInstalls": true,
   "yarnLock": undefined,
   "yarnWorkspacesPackages": undefined,
   "yarnrc": undefined,
@@ -419,6 +423,7 @@ Object {
   "packageJsonType": "app",
   "packageJsonVersion": "1.0.0",
   "pnpmShrinkwrap": undefined,
+  "skipInstalls": true,
   "yarnLock": undefined,
   "yarnWorkspacesPackages": undefined,
   "yarnrc": undefined,