Skip to content
Snippets Groups Projects
Unverified Commit ed13e22b authored by Jeff Fairley's avatar Jeff Fairley Committed by GitHub
Browse files

fix(presets): include '@typescript-eslint' with eslint preset (#6687)

* fix(presets): include '@typescript-eslint' with eslint preset

This updates the eslint package preset to include the @typescript-eslint monorepo. This is a suite of plugins and configs that enables eslint to support typescript.

* test(presets): update eslint test snapshots and expectations
parent 76eab4d7
No related branches found
No related tags found
No related merge requests found
......@@ -318,6 +318,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
],
......@@ -406,6 +407,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
],
}
......@@ -422,6 +424,7 @@ Object {
"remark-lint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
"\\\\btslint\\\\b",
......@@ -446,6 +449,7 @@ Object {
"remark-lint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
"^stylelint",
"\\\\btslint\\\\b",
......@@ -464,6 +468,7 @@ Object {
"babel-eslint",
],
"packagePatterns": Array [
"^@typescript-eslint/",
"^eslint",
],
},
......
......@@ -143,14 +143,14 @@ describe('config/presets', () => {
config.extends = ['packages:eslint'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.packagePatterns).toHaveLength(1);
expect(res.packagePatterns).toHaveLength(2);
});
it('resolves linters', async () => {
config.extends = ['packages:linters'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.packageNames).toHaveLength(3);
expect(res.packagePatterns).toHaveLength(3);
expect(res.packagePatterns).toHaveLength(4);
});
it('resolves nested groups', async () => {
config.extends = [':automergeLinters'];
......@@ -159,7 +159,7 @@ describe('config/presets', () => {
const rule = res.packageRules[0];
expect(rule.automerge).toBe(true);
expect(rule.packageNames).toHaveLength(3);
expect(rule.packagePatterns).toHaveLength(3);
expect(rule.packagePatterns).toHaveLength(4);
});
it('migrates automerge in presets', async () => {
config.extends = ['ikatyang:library'];
......
......@@ -21,7 +21,7 @@ export const presets: Record<string, Preset> = {
eslint: {
description: 'All eslint packages',
packageNames: ['babel-eslint'],
packagePatterns: ['^eslint'],
packagePatterns: ['^@typescript-eslint/', '^eslint'],
},
stylelint: {
description: 'All stylelint packages',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment