Skip to content
Snippets Groups Projects
Unverified Commit f4ebbb78 authored by Eric Citaire's avatar Eric Citaire Committed by GitHub
Browse files

fix(git-submodules): sequential submodules processing (#11659) (#11661)

parent 955942b5
No related branches found
No related tags found
No related merge requests found
...@@ -98,40 +98,33 @@ export default async function extractPackageFile( ...@@ -98,40 +98,33 @@ export default async function extractPackageFile(
return null; return null;
} }
const deps = ( const deps = [];
await Promise.all( for (const { name, path } of depNames) {
depNames.map(async ({ name, path }) => { try {
try { const [currentDigest] = (await git.subModule(['status', path]))
const [currentDigest] = (await git.subModule(['status', path])) .trim()
.trim() .replace(/^[-+]/, '')
.replace(/^[-+]/, '') .split(/\s/);
.split(/\s/); const subModuleUrl = await getUrl(git, gitModulesPath, name);
const subModuleUrl = await getUrl(git, gitModulesPath, name); // hostRules only understands HTTP URLs
// hostRules only understands HTTP URLs // Find HTTP URL, then apply token
// Find HTTP URL, then apply token let httpSubModuleUrl = getHttpUrl(subModuleUrl);
let httpSubModuleUrl = getHttpUrl(subModuleUrl); httpSubModuleUrl = getRemoteUrlWithToken(httpSubModuleUrl);
httpSubModuleUrl = getRemoteUrlWithToken(httpSubModuleUrl); const currentValue = await getBranch(
const currentValue = await getBranch( gitModulesPath,
gitModulesPath, name,
name, httpSubModuleUrl
httpSubModuleUrl );
); deps.push({
return { depName: path,
depName: path, lookupName: getHttpUrl(subModuleUrl),
lookupName: getHttpUrl(subModuleUrl), currentValue,
currentValue, currentDigest,
currentDigest, });
}; } catch (err) /* istanbul ignore next */ {
} catch (err) /* istanbul ignore next */ { logger.warn({ err }, 'Error mapping git submodules during extraction');
logger.warn( }
{ err }, }
'Error mapping git submodules during extraction'
);
return null;
}
})
)
).filter(Boolean);
return { deps, datasource: datasourceGitRefs.id }; return { deps, datasource: datasourceGitRefs.id };
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment