Skip to content
Snippets Groups Projects
Unverified Commit fe2ed94b authored by ajhcpt's avatar ajhcpt Committed by GitHub
Browse files

feat(go): Continue processing if an error occurs trying to get sourceUrl (#17981)

parent e29d851c
No related branches found
No related tags found
No related merge requests found
...@@ -515,5 +515,31 @@ describe('modules/datasource/go/releases-goproxy', () => { ...@@ -515,5 +515,31 @@ describe('modules/datasource/go/releases-goproxy', () => {
expect(res).toBeNull(); expect(res).toBeNull();
}); });
it('handles soureUrl fetch errors', async () => {
process.env.GOPROXY = baseUrl;
httpMock
.scope(`${baseUrl}/custom.com/lib/btree`)
.get('/@v/list')
.reply(200, ['v1.0.0 2018-08-13T15:31:12Z', 'v1.0.1'].join('\n'))
.get('/@v/v1.0.1.info')
.reply(200, { Version: 'v1.0.1', Time: '2019-10-16T16:15:28Z' });
httpMock
.scope('https://custom.com/lib/btree')
.get('?go-get=1')
.reply(500);
const res = await datasource.getReleases({
packageName: 'custom.com/lib/btree',
});
expect(res).toEqual({
releases: [
{ releaseTimestamp: '2018-08-13T15:31:12Z', version: 'v1.0.0' },
{ releaseTimestamp: '2019-10-16T16:15:28Z', version: 'v1.0.1' },
],
});
});
}); });
}); });
...@@ -68,9 +68,17 @@ export class GoProxyDatasource extends Datasource { ...@@ -68,9 +68,17 @@ export class GoProxyDatasource extends Datasource {
} }
}); });
if (releases.length) { if (releases.length) {
const datasource = await BaseGoDatasource.getDatasource(packageName); try {
const datasource = await BaseGoDatasource.getDatasource(
packageName
);
const sourceUrl = getSourceUrl(datasource); const sourceUrl = getSourceUrl(datasource);
result = { releases, sourceUrl }; result = { releases, sourceUrl };
} catch (err) {
logger.trace({ err }, `Can't get datasource for ${packageName}`);
result = { releases };
}
break; break;
} }
} catch (err) { } catch (err) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment