-
- Downloads
Refactor _makeBadgeData -> coalesceBadge (#2859)
`base.js` is pretty long and `_makeBadgeData` is one of the most complex functions in it. It's a pure function so it's easy to test in isolation. This moves the function into its own module and reorganizes the tests in a way that makes it evaluate what it's doing, and easier to test what is and isn't covered. Ref https://github.com/badges/shields/pull/2796#discussion_r249251008
Showing
- core/base-service/base-non-memory-caching.js 8 additions, 1 deletioncore/base-service/base-non-memory-caching.js
- core/base-service/base-static.js 8 additions, 1 deletioncore/base-service/base-static.js
- core/base-service/base.js 7 additions, 145 deletionscore/base-service/base.js
- core/base-service/base.spec.js 0 additions, 240 deletionscore/base-service/base.spec.js
- core/base-service/coalesce-badge.js 151 additions, 0 deletionscore/base-service/coalesce-badge.js
- core/base-service/coalesce-badge.spec.js 257 additions, 0 deletionscore/base-service/coalesce-badge.spec.js
- core/base-service/transform-example.js 7 additions, 1 deletioncore/base-service/transform-example.js
Loading
Please register or sign in to comment