Skip to content
Snippets Groups Projects
Unverified Commit 5d63effa authored by Paul Melnikow's avatar Paul Melnikow Committed by GitHub
Browse files

Fix a crasher in production (#2313)

When I deployed 5e99aad2 to s0, shortly after Sentry picked up an unhandled error. I'm not sure which of the legacy badges this is in.

The bug was introduced just now, in #2257. Oops!

A test would have caught this, but I don't think it's worth wrapping tests around this difficult-to-test code. It makes more sense I think, to refactor the remaining badges that use it, replace it with something using async/await (maybe based on [node-cache](https://www.npmjs.com/package/node-cache), and test that.
parent b68ac160
Branches
Tags
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment