Skip to content
Snippets Groups Projects
Commit 93333509 authored by Caleb Cartwright's avatar Caleb Cartwright Committed by chris48s
Browse files

Fix [NpmDependencyVersion] (#3274)

* fix(NpmDependencyVersion): refs #3271

* refactor(NpmDependencyVersion): tweaked route based on PR feedback
parent 167fb89f
Branches
Tags
No related merge requests found
......@@ -14,7 +14,8 @@ module.exports = class NpmDependencyVersion extends NpmBase {
static get route() {
return {
base: 'npm/dependency-version',
pattern: ':scope(@[^/]+)?/:packageName/:kind(dev|peer)?/:dependency',
pattern:
':scope(@[^/]+)?/:packageName/:kind(dev|peer)?/:dependencyScope(@[^/]+)?/:dependency',
queryParamSchema,
}
}
......@@ -34,6 +35,20 @@ module.exports = class NpmDependencyVersion extends NpmBase {
}),
keywords,
},
{
title: 'npm peer dependency version (scoped)',
pattern: ':scope?/:packageName/dev/:dependencyScope?/:dependency',
namedParams: {
scope: '@swellaby',
packageName: 'eslint-config',
dependency: 'eslint',
},
staticPreview: this.render({
dependency: 'eslint',
range: '^3.0.0',
}),
keywords,
},
{
title: 'npm dev dependency version',
pattern: ':packageName/dev/:dependency',
......@@ -47,6 +62,20 @@ module.exports = class NpmDependencyVersion extends NpmBase {
}),
keywords,
},
{
title: 'npm dev dependency version (scoped)',
pattern: ':scope?/:packageName/dev/:dependencyScope?/:dependency',
namedParams: {
packageName: 'mocha',
dependencyScope: '@mocha',
dependency: 'contributors',
},
staticPreview: this.render({
dependency: '@mocha/contributors',
range: '^1.0.3',
}),
keywords,
},
{
title: 'npm (prod) dependency version',
pattern: ':packageName/:dependency',
......@@ -60,6 +89,20 @@ module.exports = class NpmDependencyVersion extends NpmBase {
}),
keywords,
},
{
title: 'npm (prod) dependency version (scoped)',
pattern: ':scope?/:packageName/:dependencyScope?/:dependency',
namedParams: {
packageName: 'got',
dependencyScope: '@sindresorhus',
dependency: 'is',
},
staticPreview: this.render({
dependency: '@sindresorhus/is',
range: '^0.15.0',
}),
keywords,
},
]
}
......@@ -82,7 +125,10 @@ module.exports = class NpmDependencyVersion extends NpmBase {
namedParams,
queryParams
)
const { kind, dependency: wantedDependency } = namedParams
const { kind, dependency, dependencyScope } = namedParams
const wantedDependency = `${
dependencyScope ? `${dependencyScope}/` : ''
}${dependency}`
const {
dependencies,
......
......@@ -24,6 +24,13 @@ t.create('gets the dev dependency version (scoped)')
message: semverRange,
})
t.create('gets the dev dependency version (scoped dependency)')
.get('/mocha/dev/@mocha/contributors.json')
.expectBadge({
label: '@mocha/contributors',
message: semverRange,
})
t.create('gets the prod dependency version')
.get('/react-boxplot/simple-statistics.json')
.expectBadge({
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment