-
- Downloads
AccessSecretStorageDialog: fix inability to enter recovery key (#30090)
* BaseDialog: fix documentation, and make `onFinished` optional Since `onFinished` isn't used if `hasCancel` is false, it's a bit silly to make it mandatory. * AccessSecretStorageDialog: fix inability to enter recovery key Wrap AccessSecretStorageDialog in a `BaseDialog`. The main thing this achieves is a `FocusLock`. * playwright: factor out helper for verification We have two copies of the same code, and we're about to add a third... * playwright: test for verifying from Settings * Add a unit test for BaseDialog
Showing
- playwright/e2e/crypto/device-verification.spec.ts 29 additions, 22 deletionsplaywright/e2e/crypto/device-verification.spec.ts
- src/components/views/dialogs/BaseDialog.tsx 19 additions, 8 deletionssrc/components/views/dialogs/BaseDialog.tsx
- src/components/views/dialogs/security/AccessSecretStorageDialog.tsx 13 additions, 8 deletions...ents/views/dialogs/security/AccessSecretStorageDialog.tsx
- test/unit-tests/components/views/dialogs/BaseDialog-test.tsx 21 additions, 0 deletionstest/unit-tests/components/views/dialogs/BaseDialog-test.tsx
Loading
Please register or sign in to comment