Skip to content
Snippets Groups Projects
Commit 138d99a0 authored by Rhys Arkins's avatar Rhys Arkins
Browse files

feat: default lockFileMaintenance to disabled (#1066)

Closes #590

BREAKING CHANGE: lock file maintenance is now disabled by default.
parent 950c65f8
No related merge requests found
...@@ -691,7 +691,7 @@ Obviously, you can't set repository or package file location with this method. ...@@ -691,7 +691,7 @@ Obviously, you can't set repository or package file location with this method.
<td>Configuration for lock file maintenance</td> <td>Configuration for lock file maintenance</td>
<td>json</td> <td>json</td>
<td><pre>{ <td><pre>{
"enabled": true, "enabled": false,
"recreateClosed": true, "recreateClosed": true,
"branchName": "{{branchPrefix}}lock-file-maintenance", "branchName": "{{branchPrefix}}lock-file-maintenance",
"commitMessage": "Update lock file", "commitMessage": "Update lock file",
......
...@@ -534,7 +534,7 @@ const options = [ ...@@ -534,7 +534,7 @@ const options = [
stage: 'packageFile', stage: 'packageFile',
type: 'json', type: 'json',
default: { default: {
enabled: true, enabled: false,
recreateClosed: true, recreateClosed: true,
branchName: template('branchName', 'lock-file-maintenance'), branchName: template('branchName', 'lock-file-maintenance'),
commitMessage: template('commitMessage', 'lock-file-maintenance'), commitMessage: template('commitMessage', 'lock-file-maintenance'),
......
...@@ -4,7 +4,7 @@ exports[`config/index mergeChildConfig(parentConfig, childConfig) merges 1`] = ` ...@@ -4,7 +4,7 @@ exports[`config/index mergeChildConfig(parentConfig, childConfig) merges 1`] = `
Object { Object {
"branchName": "{{branchPrefix}}lock-file-maintenance", "branchName": "{{branchPrefix}}lock-file-maintenance",
"commitMessage": "Update lock file", "commitMessage": "Update lock file",
"enabled": true, "enabled": false,
"groupName": null, "groupName": null,
"prBody": "This {{#if isGitHub}}Pull{{else}}Merge{{/if}} Request updates \`package.json\` lock files to use the latest dependency versions. "prBody": "This {{#if isGitHub}}Pull{{else}}Merge{{/if}} Request updates \`package.json\` lock files to use the latest dependency versions.
......
...@@ -52,6 +52,7 @@ describe('packageFileWorker', () => { ...@@ -52,6 +52,7 @@ describe('packageFileWorker', () => {
expect(res).toHaveLength(0); expect(res).toHaveLength(0);
}); });
it('maintains lock files', async () => { it('maintains lock files', async () => {
config.lockFileMaintenance.enabled = true;
config.yarnLock = '# some yarn lock'; config.yarnLock = '# some yarn lock';
const res = await packageFileWorker.renovatePackageFile(config); const res = await packageFileWorker.renovatePackageFile(config);
expect(res).toHaveLength(1); expect(res).toHaveLength(1);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment